GH-49751: [Python] Add raw fd support to pa.OSFile - #49750
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
alippai
changed the title
|
|
|
@pitrou I see you have changes in the files affected. Is this a good direction? |
github-actions
Bot
added
awaiting committer review
|
Thanks a lot @alippai , I'll merge now. |
|
Thanks, @pitrou! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 210a856. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change The goal of the MR is to support the low level python raw fds (`os.open()`) ### What changes are in this PR? As an alternative to the `str` path, the `pa.OSFile` accepts the `int` parameter as well. ### Are these changes tested? Yes, new end-to-end tests were added ### Are there any user-facing changes? Yes, the API is extended with a new parameter type This MR was created by Codex Cloud. * GitHub Issue: apache#49751 Authored-by: Ádám Lippai <adam@rigo.sk> Signed-off-by: Antoine Pitrou <antoine@python.org>
2 participants
Rationale for this change
The goal of the MR is to support the low level python raw fds (
os.open())What changes are in this PR?
As an alternative to the
strpath, thepa.OSFileaccepts theintparameter as well.Are these changes tested?
Yes, new end-to-end tests were added
Are there any user-facing changes?
Yes, the API is extended with a new parameter type
This MR was created by Codex Cloud.